Skip to content

Pluggable discovery (WIP) #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Pluggable discovery (WIP) #109

wants to merge 12 commits into from

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jan 7, 2019

No description provided.

cmaglie added 12 commits January 7, 2019 16:54
@cmaglie
Use PlatformRelease.IsInstalled() method when appropriate
bfa02dd
@cmaglie
Added methods to cycle on all installed platforms or boards
50ab64f
@cmaglie
board list: reduced timeout to 1s
09b4da6
@cmaglie
discovery: first implementation (WIP)
7662cfa
@cmaglie
discovery: Do not start process on Discovery creation
289f6d5 
Added a Start method for that and now Close will also kill the
running process.
@cmaglie
discovery: added timeout on LIST command
e50f391
@cmaglie
discovery: Timeout is now configurable
4a84564
@cmaglie
discovery: Added method to retrieve all installed discoveries
e95a6da
@cmaglie
discovery: Added method to identify boards from BoardPort identificat…
093b044 
…ion properties
@cmaglie
board list command now uses pluggable-discoveries
916bc3e
@cmaglie
discovery: serial-discovery is now downloaded automatically
7b6a23b
@cmaglie
Removed direct dependency (to make dep check happy)
74a04db
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-32-PR109-linux64.tar.bz2

⬇️ Linux 32: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-32-PR109-linux32.tar.bz2

⬇️ Linux ARM: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-32-PR109-linuxarm.tar.bz2

⬇️ Windows: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-32-PR109-windows.zip

⬇️ OSX: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-32-PR109-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@arduino arduino deleted a comment from ArduinoBot Jan 7, 2019
@codecov
Copy link

codecov bot commented Jan 7, 2019 •
edited
Loading

Codecov Report

Merging #109 into master will increase coverage by 0.91%.
The diff coverage is 1.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   47.77%   48.68%   +0.91%     
==========================================
  Files          92       95       +3     
  Lines        4113     4262     +149     
==========================================
+ Hits         1965     2075     +110     
- Misses       1911     1926      +15     
- Partials      237      261      +24
Impacted Files Coverage Δ
arduino/discovery/discovery.go 0% <0%> (ø)
commands/board/serial.go 0% <0%> (ø)
arduino/cores/packagemanager/package_manager.go 46.35% <0%> (-1.11%) ⬇️
arduino/cores/packagemanager/identify.go 0% <0%> (ø)
arduino/cores/cores.go 78.31% <100%> (+4.81%) ⬆️
commands/board/list.go 10.67% <3.26%> (-4.19%) ⬇️
configs/configuration.go 79.16% <0%> (-2.66%) ⬇️
configs/yaml_serializer.go 23.72% <0%> (-0.8%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3819f27...74a04db. Read the comment docs.

@jwatte
Copy link

jwatte commented May 6, 2019

It would be great to have Teensyduino needs met by the "board manager" API.

@cmaglie cmaglie closed this May 24, 2019
@cmaglie cmaglie deleted the discovery branch May 24, 2019 07:46
@cmaglie
Copy link
Member Author

cmaglie commented May 24, 2019

Superseded by another pull-request that is coming.

@cmaglie cmaglie added this to the next alpha milestone May 24, 2019
per1234 pushed a commit that referenced this pull request Nov 16, 2020
@aentinger
Merge pull request #109 from arduino-libraries/add-formatting-element…
2d60fea 
…s-for-better-readability

Refactoring ArduinoIoTCloud
per1234 added a commit that referenced this pull request Aug 9, 2021
@per1234
Merge pull request #109 from arduino/per1234/add-check-ids
592badc 
Define unique IDs for all check configurations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
next alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@cmaglie @ArduinoBot @jwatte